Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container: fix storage pool resource names in test #11832

Merged
merged 1 commit into from
Sep 26, 2024
Merged

container: fix storage pool resource names in test #11832

merged 1 commit into from
Sep 26, 2024
+17 −36

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Sep 26, 2024 •
edited
Loading

Came across this when working on #11826

Tests such as
TestAccContainerNodePool_withDiskMachineAndStoragePoolUpdate seem to be failing, possibly due to being promoted from beta to v1

Rather than update the regex in extractSP, use
tpgresource.GetRelativePath() and return that from the bootstrap method, as mentioned here:
#11391 (comment)

See #11391 and #11598

Release Note Template for Downstream PRs (will be copied)

@wyardley
container: fix storage pool resource names in test
f359cf8 
Tests such as
`TestAccContainerNodePool_withDiskMachineAndStoragePoolUpdate` seem to
be failing, possibly due to being promoted from beta to v1

Rather than update the regex in extractSP, use
`tpgresource.GetRelativePath()` and return that from the bootstrap
method, as mentioned here:
GoogleCloudPlatform#11391 (comment)

See GoogleCloudPlatform#11391 and GoogleCloudPlatform#11598
@github-actions github-actions bot requested a review from zli82016 September 26, 2024 15:53
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 26, 2024
@wyardley
Copy link
Contributor Author

cc: @shuyama1

@wyardley wyardley mentioned this pull request Sep 26, 2024
Merged
@zli82016
Copy link
Member

/gcbrun

@modular-magician modular-magician added service/container and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 26, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 17 insertions(+), 36 deletions(-))
google-beta provider: Diff ( 3 files changed, 17 insertions(+), 36 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4100
Passed tests: 3685
Skipped tests: 413
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeDisk_storagePoolSpecified
  • TestAccComputeInstance_bootDisk_storagePoolSpecified

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@shuyama1
Copy link
Member

@wyardley Thank you for making the change! LGTM! I had this on my to-do list but haven't had the chance to work on it yet. Appreciate your help!

shuyama1
shuyama1 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@shuyama1 shuyama1 removed the request for review from zli82016 September 26, 2024 19:17
@shuyama1 shuyama1 merged commit 8817cec into GoogleCloudPlatform:main Sep 26, 2024
11 checks passed
This was referenced Sep 26, 2024
Merged
Merged
sebkalis pushed a commit to sebkalis/magic-modules that referenced this pull request Sep 27, 2024
@wyardley @sebkalis
container: fix storage pool resource names in test (GoogleCloudPlatfo…
d4538f3 
…rm#11832)
anavada pushed a commit to anavada/magic-modules that referenced this pull request Sep 30, 2024
@wyardley @anavada
container: fix storage pool resource names in test (GoogleCloudPlatfo…
55c0983 
…rm#11832)
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
@wyardley @niharika-98
container: fix storage pool resource names in test (GoogleCloudPlatfo…
6196065 
…rm#11832)
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
@wyardley @trodge
container: fix storage pool resource names in test (GoogleCloudPlatfo…
ce37305 
…rm#11832)
@wyardley wyardley deleted the wyardley/fix_test branch October 24, 2024 17:18
Philip-Jonany pushed a commit to Philip-Jonany/magic-modules that referenced this pull request Nov 4, 2024
@wyardley
container: fix storage pool resource names in test (GoogleCloudPlatfo…
a43fcee 
…rm#11832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacaskill amacaskill amacaskill left review comments

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees
No one assigned
Labels
service/container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wyardley @zli82016 @modular-magician @shuyama1 @amacaskill